-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New deprecated-feature module and added to Metering assemblies #31776
New deprecated-feature module and added to Metering assemblies #31776
Conversation
@vikram-redhat PTAL - adds a new |
Deploy preview for osdocs ready! Built with commit 6b21f7e |
LGTM! |
f8eab3a
to
32008c4
Compare
modules/deprecated-feature.adoc
Outdated
==== | ||
{FeatureName} is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, it will be removed in a future release of this product and is not recommended for new deployments. | ||
|
||
For the most recent list of major functionality deprecated and removed within {product-title}, refer to the _Deprecated and removed features_ section of the {product-title} release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest clarifying the wording slightly so that deprecated and removed don't sound as paired:
s/functionality deprecated and removed/functionality that has been deprecated or removed/
Left one comment but otherwise this looks great and will be very helpful. Thank you! |
f73fd1f
to
9f12c0d
Compare
@timflannagan PTAL, thanks! |
LGTM! |
/lgtm |
9f12c0d
to
6b21f7e
Compare
New changes are detected. LGTM label has been removed. |
/cherrypick enterprise-4.6 |
@lbarbeevargas: new pull request created: #32024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.8 |
@lbarbeevargas: new pull request created: #32026 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lbarbeevargas: new pull request created: #32027 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds a new
deprecated-feature.adoc
module that is based off of the tech preview module and existing wording in the Deprecated and removed features section of the release notes.In this PR, the new module is also added to the top of each Metering assembly.
A subsequent PR will add information on this new
deprecated-feature.adoc
module to the OCP doc guidelines.Preview: https://deploy-preview-31776--osdocs.netlify.app/openshift-enterprise/latest/metering/metering-about-metering.html