Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New deprecated-feature module and added to Metering assemblies #31776

Merged

Conversation

lbarbeevargas
Copy link
Contributor

@lbarbeevargas lbarbeevargas commented Apr 21, 2021

This PR adds a new deprecated-feature.adoc module that is based off of the tech preview module and existing wording in the Deprecated and removed features section of the release notes.

In this PR, the new module is also added to the top of each Metering assembly.

A subsequent PR will add information on this new deprecated-feature.adoc module to the OCP doc guidelines.

Preview: https://deploy-preview-31776--osdocs.netlify.app/openshift-enterprise/latest/metering/metering-about-metering.html

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2021
@lbarbeevargas
Copy link
Contributor Author

@vikram-redhat PTAL - adds a new deprecated-feature.adoc template module.

@netlify
Copy link

netlify bot commented Apr 21, 2021

Deploy preview for osdocs ready!

Built with commit 6b21f7e

https://deploy-preview-31776--osdocs.netlify.app

@vikram-redhat
Copy link
Contributor

LGTM!

@lbarbeevargas lbarbeevargas force-pushed the add-deprecated-feature-module branch from f8eab3a to 32008c4 Compare April 22, 2021 19:46
====
{FeatureName} is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, it will be removed in a future release of this product and is not recommended for new deployments.

For the most recent list of major functionality deprecated and removed within {product-title}, refer to the _Deprecated and removed features_ section of the {product-title} release notes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest clarifying the wording slightly so that deprecated and removed don't sound as paired:
s/functionality deprecated and removed/functionality that has been deprecated or removed/

@bobfuru
Copy link
Contributor

bobfuru commented Apr 23, 2021

Left one comment but otherwise this looks great and will be very helpful. Thank you!

@lbarbeevargas lbarbeevargas force-pushed the add-deprecated-feature-module branch 2 times, most recently from f73fd1f to 9f12c0d Compare April 27, 2021 15:52
@lbarbeevargas
Copy link
Contributor Author

@timflannagan PTAL, thanks!

@lbarbeevargas lbarbeevargas added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 27, 2021
@ahardin-rh
Copy link
Contributor

LGTM!

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 27, 2021
@pruan-rht
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@lbarbeevargas lbarbeevargas force-pushed the add-deprecated-feature-module branch from 9f12c0d to 6b21f7e Compare April 28, 2021 17:18
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@lbarbeevargas lbarbeevargas merged commit b7f0208 into openshift:master Apr 28, 2021
@lbarbeevargas
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@lbarbeevargas: new pull request created: #32024

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbarbeevargas
Copy link
Contributor Author

/cherrypick enterprise-4.7

@lbarbeevargas
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@lbarbeevargas: new pull request created: #32026

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@lbarbeevargas: new pull request created: #32027

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants